-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recurring migration job #7092
Conversation
6bf8004
to
3d6e023
Compare
Just to close the loop, I raised one important thing about this PR on Slack: p1692030035740929-slack-C04A6MB40QN |
Codecov Report
@@ Coverage Diff @@
## trunk #7092 +/- ##
============================================
+ Coverage 49.37% 49.47% +0.10%
- Complexity 10543 10569 +26
============================================
Files 575 578 +3
Lines 44527 44602 +75
Branches 402 402
============================================
+ Hits 21985 22069 +84
+ Misses 22215 22206 -9
Partials 327 327
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@merkushin I wasn't able to figure out how to make Psalm happy. I would appreciate your help. 🙏 |
@@ -13,4 +13,8 @@ | |||
<directory name="widgets" /> | |||
</ignoreFiles> | |||
</projectFiles> | |||
<issueHandlers> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks, Miro! Looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, can't approve it as I'm an author of the PR :)
😆
Resolves #5437
Proposed Changes
Testing Instructions
tables_based_progress
feature.Might be needed to do some cleanup if you tested migration before:
Pre-Merge Checklist