"kue-wide refactoring to change all static and globals" decoupling singleton #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you can also take a look on my current dev improvements on the dev branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I just discovered this awesome library this week and I would like to bring my contribution to make it further more reliable.
I've tried to keep the coding style as I found it, but it was hard because I'm accustomed to Babel, E6, and StandardJS (so it's possible that some
;are missing, cause I don't use them myself anymore ).I've introduced a new method called
getQueue, that is using the singleton, and nowcreateQueueis creating new instances (with all it's own scope, obviously).I'm on Node 9.3 and all the unit tests are working, I had to modify them a little bit but a minium.