Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photon: issues with double encoding #40290

Open
jeherve opened this issue Nov 21, 2024 · 2 comments
Open

Photon: issues with double encoding #40290

jeherve opened this issue Nov 21, 2024 · 2 comments
Assignees
Labels
[Feature] Photon aka "Image CDN". Feature developed in the Image CDN package and shipped in multiple plugins [Platform] Atomic [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@jeherve
Copy link
Member

jeherve commented Nov 21, 2024

Impacted plugin

Jetpack, Boost

Quick summary

Following #39560, some images cannot be displayed properly.

Steps to reproduce

  1. Start with a site running Photon.
  2. Go to Posts > Add New
  3. Add an image block
  4. Pick the "insert via URL" option
  5. Insert an image with a space in the file name, converted into %20
  6. Publish your post.

A clear and concise description of what you expected to happen.

I would expect the image to be displayed in the post.

What actually happened

It isn't. %20 is turned into %2520.

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

If the above answer is "Yes...", outline the workaround.

Right now, the workaround would be to not insert any images with spaces in the filename. That is something WordPress solves when you upload to the media library for example.

Platform (Simple and/or Atomic)

Atomic, Self-hosted

Logs or notes

Reported in p1732130198644889-slack-C0299DMPG

@jeherve jeherve added [Feature] Photon aka "Image CDN". Feature developed in the Image CDN package and shipped in multiple plugins [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended Triaged labels Nov 21, 2024
@jeherve jeherve moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Nov 21, 2024
@jeherve
Copy link
Member Author

jeherve commented Nov 21, 2024

@haqadn Do you think you could take a look, since you worked on #39560?

Thank you!

@haqadn haqadn self-assigned this Nov 21, 2024
@github-actions github-actions bot added [Platform] Atomic [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Feature] Images labels Nov 21, 2024
Copy link
Contributor

OpenAI suggested the following labels for this issue:

  • [Feature Group] Content Management: The issue relates to how images are managed and displayed in posts, impacting content management.
  • [Feature] Photon: The issue specifically addresses a problem with the Photon feature, which is related to image delivery and performance.
  • [Feature] Images: The issue directly pertains to image handling, particularly with URLs containing spaces.

@jeherve jeherve removed [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Experiment] AI labels added [Feature] Images labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Photon aka "Image CDN". Feature developed in the Image CDN package and shipped in multiple plugins [Platform] Atomic [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal Triaged [Type] Bug When a feature is broken and / or not performing as intended
Projects
Development

No branches or pull requests

2 participants