Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste Ad codes vs entering tag/publisher ids #84

Open
jtsternberg opened this issue Dec 3, 2013 · 5 comments
Open

Paste Ad codes vs entering tag/publisher ids #84

jtsternberg opened this issue Dec 3, 2013 · 5 comments

Comments

@jtsternberg
Copy link
Contributor

http://adcodemanager.wordpress.com/2013/12/03/hey-guys-how-do-we-feel-about-having/

We have a future vip client who may be happy to have this feature implemented.

@danielbachhuber
Copy link
Contributor

I'm open to suggestions on what the interface might look like. Considering it's a secondary feature, and might only be supported for some providers, what about having a link or similar that, after clicking, would replace the input fields with the textarea?

The user would then paste their given ad code, hit "Add New Ad Code", and the code would be interpreted into variables.

How do you envision parsing the ad code?

@jtsternberg
Copy link
Contributor Author

That UI convention sounds fine to me. As far as parsing, might be good to start with some standard stri_replace strings that match conventionally provided ad codes and then a pregmatch after that.

@danielbachhuber
Copy link
Contributor

Cool, I'd be happy to look at a PR for this.

@jtsternberg
Copy link
Contributor Author

Ok, hope to tackle the related project in the next couple weeks, so will submit a PR as soon as I can.

@rcoll
Copy link
Member

rcoll commented Dec 12, 2013

Awesome idea. Happy to jump in if needed.

@GaryJones GaryJones added this to the Unscheduled milestone Mar 14, 2022
@GaryJones GaryJones removed this from the Future Release milestone Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants