Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vending Machine Launch Fix #20215

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Vending Machine Launch Fix #20215

wants to merge 6 commits into from
+174 −66

Conversation

Ben10083
Copy link
Contributor

@Ben10083 Ben10083 commented Nov 29, 2024 •
edited
Loading

Fixes #20201

Fixes runtime in SSThrowing by having non-mobs default to targeting chest
Refactors vendor reply code to be similar to how it handles ads and slogans
Fixes interaction involving using a string to get the coin back from vending machine

@BotBOREALIS BotBOREALIS added Review Required Bugfix The PR is fixing an issue and requires less reviews and time to be ready for merging. labels Nov 29, 2024
FluffyGhoster
FluffyGhoster requested changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@FluffyGhoster FluffyGhoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't an acceptable fix, the parameter of this proc types that var as a mob, if the caller isn't respecting the proc signature it's an issue of what calls it, not of the proc

@Ben10083
Copy link
Contributor Author

This isn't an acceptable fix, the parameter of this proc types that var as a mob, if the caller isn't respecting the proc signature it's an issue of what calls it, not of the proc

Unsure how to resolve in a different way, contacting you over discord

@github-actions github-actions bot added the 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files. label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FluffyGhoster FluffyGhoster Awaiting requested review from FluffyGhoster

@NonQueueingMatt NonQueueingMatt Awaiting requested review from NonQueueingMatt NonQueueingMatt is a code owner

@DreamySkrell DreamySkrell Awaiting requested review from DreamySkrell DreamySkrell is a code owner

Assignees
No one assigned
Labels
Bugfix The PR is fixing an issue and requires less reviews and time to be ready for merging. 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files. Review Required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Vendors throwing items doesn't work.
3 participants
@Ben10083 @FluffyGhoster @BotBOREALIS