Skip to content
This repository has been archived by the owner on May 16, 2021. It is now read-only.

[FR] Allow adding a CSS class to field to avoid unwanted transformation #455

Open
pryley opened this issue Dec 17, 2018 · 0 comments
Open

Comments

@pryley
Copy link

pryley commented Dec 17, 2018

I am the author of star-rating.js, a script that transforms a SELECT rating field into a star rating control.

I use this script in a WordPress plugin that provides ratings and reviews.

When the Uniform script is used in WordPress themes, it usually is triggered on all form fields, i.e

$("select:not([multiple]), input:checkbox, input:radio, input:file").uniform();

This makes the theme incompatible with the reviews plugin as the Uniform script adjusts the DOM which breaks the star-rating.js script. This is primarily a CSS issue as I could fix this (and likely will) by un-setting all of the CSS rules that Uniform sets on the star-rating control.

However, a far simpler solution would be for the Uniform script to check for a particular class, which if exists, would tell Uniform not to transform the element.

e.g.

<!-- Do not transform elements that have the ".browser-default" CSS class -->
<select class="browser-default"> ... </select>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants