Seeking

[p0nce]

• MP3
• WAV
• OGG
• XM
• MOD
• FLAC
• OPUS
• implement a canSeek function, and a isModule function
• complete seeking for modules

[p0nce]

OGG seek fails, we're at stb_vorbis 1.10

The subsequent commits that talks about seeking are:
commit 7c4eb44a636ab398b1aea872e4f5792ad66d7706
Author: Dougall Johnson <[email protected]>
Date:   Tue Oct 1 20:47:29 2019 +1000

    stb_vorbis: fix seeking in files with audio packets in header pages

    Fixes #682, #580

commit 2abc5c6ced37e2d70a5e7401dbbb9cfc5700995e
Author: Dougall Johnson <[email protected]>
Date:   Tue Oct 1 16:37:22 2019 +1000

    stb_vorbis: fix seek_to_sample_coarse failure near page end

commit 6ca87a9e0ec90ace080f172ecda3e1850c8b4beb
Author: Dougall Johnson <[email protected]>
Date:   Tue Oct 1 16:36:41 2019 +1000

    stb_vorbis: fix theoretical seek performance problem


commit d2de2be10fdb1cf459e194b40302af8f6a8a0c7b
Author: Sean Barrett <[email protected]>
Date:   Fri Mar 3 05:48:37 2017 -0800

    vorbis: propagate errors better on seek failure (e.g. when coarse seek fails)

[p0nce]

Backported 2abc5c6ced37e2d70a5e7401dbbb9cfc5700995e and 7c4eb44a636ab398b1aea872e4f5792ad66d7706 but no better with OGG.

[p0nce]

For OGG best course of action is to re-re-translate stb_vorbis.c

[p0nce]

Current situation:

• WAV seeking works, is sample accurate.
• MP3 seeking works, haven't check accuracy. (EDIT: sample-accurate)
• FLAC seeking works, is sample accurate.
• OPUS is not sample accurate (usually a 64ms difference), haven't checked mono support.

Others not implemented.

[p0nce]

Tag v1.3.6 for that above state.

[p0nce]

OGG seeking with new stb_vorbis 1.22 translation in v1.3.7

[p0nce]

@LunaTheFoxgirl I think canSeek can be instead isModule?

Spec time!

If isModule, then you get to use the module function you introduced.
if !isModule, then you can use seekPosition() and tellPosition() ; those do not make sense in tracker module.

What do you think? (also, name for isModule?)

[LunaTheFoxgirl]

Maybe both? There may be audio formats added in the future that don't support seeking right away, you'd need to be able to query that too.

Also if more tracker formats are added later you'd need to be able to tell if that's seekable too (MOD files weren't initially seekable so I had to write my own small implementation for that, for example)

[p0nce]

Both then.