Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeasurementAnalyticsClient.AdjustUriBeforeRequest cuts strings with special chars #39

Open
xmedeko opened this issue Sep 2, 2015 · 2 comments

Comments

@xmedeko
Copy link

xmedeko commented Sep 2, 2015

Sent strings are malformed in the MeasurementAnalyticsClient.AdjustUriBeforeRequest method, when a string contains chars = or &.

E.g. sending

AutoMeasurement.Client.TrackEvent("My Action", "My Custom Category", "My Label id=345");

results in sending label="My Label id" only.

I've solved problem either by using UriFormat.UriEscaped, or fix GetQueryParameters method by q.Split(new char[] {'='}, 2). (Just one of this fix solved problem.)

Note: Such Uri construction, parsing and again construction is often source of problems. (My experience from several other applications.) Better to avoid it. Just construct the right Uri once and send it.

@damieng
Copy link
Contributor

damieng commented Sep 2, 2015

A heads up this project is no longer under active development. (it hasn't been touched in 7 months)

@xmedeko
Copy link
Author

xmedeko commented Sep 2, 2015

It's pity to leave such popular project - about 120 stars, 30 forks. May you write it to the README.md, that you no longer actively develop this project? What about trying to find another maintainer?

If I send a pul request, will you merge it and release a new version?
Thanks

@xmedeko xmedeko changed the title MeasurementAnalyticsClient.AdjustUriBeforeRequest cut strings with contain equal char MeasurementAnalyticsClient.AdjustUriBeforeRequest cuts strings with special chars Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants