Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent new user assertion statuses on the same flag deleting old ones #919

Open
peggynewman opened this issue Sep 25, 2024 · 1 comment

Comments

@peggynewman
Copy link

peggynewman commented Sep 25, 2024

Example situation: a user flags a record. A resolver sees the flag, acknowledges an error exists and knows why, but cannot resolve it for whatever reason (let’s say an expert need to re-det the voucher, but they won’t be at the herbarium for two months). In this case, the resolver can verify the flag with the ‘Unresolved issue, recognised by data custodian’ user assertion status. This is helpful as it provides an update to the flagger/any other user inspecting the record and indicates that something is being done about it, but keeps the flag active in the interim until it is actually resolved.

In two months’ time, the issue gets fixed, so the resolver adds another verification, this time selecting the status ‘Corrected via data refresh’. However, doing so deletes the initial verification and explanatory comment. That original comment/context is now permanently lost. This needs to be resolved so the full history of comments/statuses attached to each flag is retained.

cc @tmesaglio for testing

@adam-collins
Copy link
Contributor

I expect this is a change to the biocache-service user assertion consolidation found at AssertionService.getCombinedAssertions

It requires the removal of the function's requirement and implementation for

// 2. for verified assertion (whose code == 50000), it's uniquely related to an assertion.
//    so if there's already a verification for an assertion, a newly created verification on same assertion will overwrite existing one
//    verification is unique per assertion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants