Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rewards transactions to dapp staking history #106

Merged
merged 13 commits into from
Aug 31, 2023
Merged

Conversation

bobo-k2
Copy link
Contributor

@bobo-k2 bobo-k2 commented Aug 30, 2023

All rewards claimed in single batch call will be returned as one transactions with sum of all rewards for that batch.

Please test locally.

@github-actions
Copy link

github-actions bot commented Aug 30, 2023

Visit the preview URL for this PR (updated for commit 1214a5a):

https://astar-token-api--pr106-feat-rewards-history-pmgg2l47.web.app

(expires Wed, 06 Sep 2023 21:48:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f99fa4f4f8f3bb450e6e842f7e1c7783d6d896a3

@bobo-k2 bobo-k2 requested review from impelcrypto and gluneau August 30, 2023 06:39
@bobo-k2 bobo-k2 marked this pull request as ready for review August 30, 2023 06:39
@bobo-k2 bobo-k2 changed the title Add rewards transactions to history history Add rewards transactions to dapp staking history Aug 30, 2023
Copy link
Contributor

@gluneau gluneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and it works

@bobo-k2 bobo-k2 merged commit c83d54f into prod Aug 31, 2023
5 checks passed
@bobo-k2 bobo-k2 deleted the feat/rewards-history branch August 31, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants