Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move vote leaderboard to the page bottom #1406

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bobo-k2
Copy link
Contributor

@bobo-k2 bobo-k2 commented Oct 24, 2024

Pull Request Summary

Moved voting period leaderboard to the end of dApp staking page

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

gtg7784 and others added 5 commits October 14, 2024 18:51
* add lfgm link to links

* add lfgm asset

* add lfgm image to desktop sidebar

* add lfgm image to mobile nav

* add target as block to open new window
* hide blog section

* add forum to mobile nav
* Remove leaderboard for voting period

* Added empty div instead voting leaderboard to preserve vertical spacing
* Delete Neurolanche from dapp_promotions.json

* Delete public/images/dapp_promotions/neurolanche.jpeg
Copy link

Visit the preview URL for this PR (updated for commit 925ac07):

https://astar-apps--pr1406-fix-vote-leaderboard-z8c6hrdj.web.app

(expires Thu, 31 Oct 2024 06:36:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

Copy link
Member

@gtg7784 gtg7784 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you!

@bobo-k2 bobo-k2 marked this pull request as draft October 24, 2024 08:34
Base automatically changed from release-hotfix to main October 28, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants