Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/remove ethers #1395

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Refactor/remove ethers #1395

wants to merge 4 commits into from

Conversation

codespool
Copy link

Pull Request Summary

Describe what changes this pull request makes to the repository

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Adds

  • add custom implementations of formatEther for both number and string output
    • uses viem formatEther version
    • takes bigInt, string or BN as input

Changes

  • replace all references to ethers.util.formatEther with custom impl.

To-dos

  • replace ethers client with viem
  • remove the rest of ethers references

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@codespool