make build.js working on macOS and a little easier to use #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pinxue thank you for your contribution! We will review your pull request as soon as possible. 👍 |
|
I don't have Macos to test. I think is building the frontend (from source) is a good idea! New users / developers expect a working tool, which includes a frontend. |
|
@pinxue it would be nice if you want to join https://gitter.im/asch-development/Lobby |
|
OK, let me try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sed in macOS is a bit different, -i '' is not optional.
Install frontend files from asch-frontend-2 project while building.
And add 'all' for build.js to create all packages at once.