Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish proposals and gateways feature #35

Open
a1300 opened this issue Sep 20, 2018 · 0 comments
Open

Finish proposals and gateways feature #35

a1300 opened this issue Sep 20, 2018 · 0 comments

Comments

@a1300
Copy link
Contributor

a1300 commented Sep 20, 2018

Dear @liangpeili, please assign this issue to me!

TODO's copyied from #21

TODO

  1. Proposal.js Line 72
    1.1 Variable keys is not used. Variable can be removed
  2. For the propsal.upvote function, it would be easier to pass the transactionId as a variable, instead in the options object
    2.1 same for proposal.activate
  3. In proposal.js please rename
    3.1 activate -> activateProposal 3.2 upvote->upvoteProposal 3.3 Maybe you could also provide the functionrevokeProposal`
  4. For initgateway and I would make the name optional. Instead of hardcoding xxxxxxxxxx. You could make this parmaeter optional.
  5. Add proposal.revokeProposal contract function
  6. Add Typescript definitions for proposal.js and gateway.js
liangpeili added a commit that referenced this issue Oct 8, 2018
feat(proposal): Finish proposal and gateway features, closes #35
@a1300 a1300 changed the title Finish poposals and gateways feature Finish proposals and gateways feature Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant