You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Proposal.js Line 72
1.1 Variable keys is not used. Variable can be removed
For the propsal.upvote function, it would be easier to pass the transactionId as a variable, instead in the options object
2.1 same for proposal.activate
In proposal.js please rename
3.1 activate -> activateProposal 3.2 upvote->upvoteProposal 3.3 Maybe you could also provide the functionrevokeProposal`
For initgateway and I would make the name optional. Instead of hardcoding xxxxxxxxxx. You could make this parmaeter optional.
Add proposal.revokeProposal contract function
Add Typescript definitions for proposal.js and gateway.js
The text was updated successfully, but these errors were encountered:
a1300
added a commit
to a1300/asch-js
that referenced
this issue
Sep 22, 2018
Dear @liangpeili, please assign this issue to me!
TODO
1.1 Variable
keys
is not used. Variable can be removedpropsal.upvote
function, it would be easier to pass thetransactionId
as a variable, instead in theoptions
object2.1 same for
proposal.activate
proposal.js
please rename3.1
activate
->activateProposal 3.2
upvote->
upvoteProposal3.3 Maybe you could also provide the function
revokeProposal`initgateway
and I would make the name optional. Instead of hardcodingxxxxxxxxxx
. You could make this parmaeter optional.proposal.revokeProposal
contract functionproposal.js
andgateway.js
The text was updated successfully, but these errors were encountered: