Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): add configurable base url #4709

Merged
merged 1 commit into from
Sep 21, 2024
Merged

feat(auth): add configurable base url #4709

merged 1 commit into from
Sep 21, 2024

Conversation

axiomofjoy
Copy link
Contributor

@axiomofjoy axiomofjoy commented Sep 20, 2024

Adds PHOENIX_BASE_URL parameter. Similar to root_url in Grafana.

The URL used to access Phoenix from a browser. This is needed to ensure that the
`redirect_uri` parameter is correct during OAuth2 authorization code flows if an
OAuth2 IDP is configured. If you have a reverse proxy in front of Phoenix that
exposes Phoenix through a subpath, ensure that the subpath appears at the end of
this URL. Strongly consider using HTTPS since HTTP is insecure.

resolves #4690

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Sep 20, 2024
@axiomofjoy axiomofjoy changed the base branch from main to auth September 20, 2024 23:36
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Sep 20, 2024
@axiomofjoy axiomofjoy merged commit 21e05b4 into auth Sep 21, 2024
6 checks passed
@axiomofjoy axiomofjoy deleted the xander/base-url branch September 21, 2024 01:24
RogerHYang pushed a commit that referenced this pull request Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[auth][oauth] add oauth2 origin env var
2 participants