You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When running the playground on a dataset if you hit an unhandled error the subscription onCompleted callback runs but not the onError (this is not the case with the mutation).
To Reproduce
Steps to reproduce the behavior:
Go to playground
select a dataset
switch to an anthropic model
don't set the max tokens (required, will throw)
click run and see subscription complete with no info
Expected behavior
onError would run (since unhandled) and user would be notified or error
Additional context
onCompleted is running when the error is hit
error stack from server for one of the examples in the dataset, this same stack is logged for all examples in dataset
Required parameter max_tokens not provided
Traceback (most recent call last):
File "/Users/parkerstafford/Library/Application Support/uv/tools/arize-phoenix/lib/python3.12/site-packages/phoenix/server/api/subscriptions.py", line 290, in chat_completion_over_dataset
yield task.result()
^^^^^^^^^^^^^
File "/Users/parkerstafford/Library/Application Support/uv/python/cpython-3.12.4-macos-aarch64-none/lib/python3.12/asyncio/tasks.py", line 520, in wait_for
return await fut
^^^^^^^^^
File "/Users/parkerstafford/Library/Application Support/uv/tools/arize-phoenix/lib/python3.12/site-packages/phoenix/server/api/subscriptions.py", line 435, in _as_coroutine
return await iterable.__anext__()
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/parkerstafford/Library/Application Support/uv/tools/arize-phoenix/lib/python3.12/site-packages/phoenix/server/api/subscriptions.py", line 326, in _stream_chat_completion_over_dataset_example
invocation_parameters = llm_client.construct_invocation_parameters(input.invocation_parameters)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/parkerstafford/Library/Application Support/uv/tools/arize-phoenix/lib/python3.12/site-packages/phoenix/server/api/helpers/playground_clients.py", line 209, in construct_invocation_parameters
validate_invocation_parameters(supported_params, formatted_invocation_parameters)
File "/Users/parkerstafford/Library/Application Support/uv/tools/arize-phoenix/lib/python3.12/site-packages/phoenix/server/api/input_types/InvocationParameters.py", line 147, in validate_invocation_parameters
raise ValueError(f"Required parameter {param_def.invocation_name} not provided")
The text was updated successfully, but these errors were encountered:
Describe the bug
When running the playground on a dataset if you hit an unhandled error the subscription onCompleted callback runs but not the onError (this is not the case with the mutation).
To Reproduce
Steps to reproduce the behavior:
Expected behavior
onError would run (since unhandled) and user would be notified or error
Additional context
onCompleted is running when the error is hit
error stack from server for one of the examples in the dataset, this same stack is logged for all examples in dataset
The text was updated successfully, but these errors were encountered: