Don't continue on failure

Arize-ai · Sep 20, 2024 · 165bec1 · 165bec1
1 parent 036a170
commit 165bec1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/python-CI.yml b/.github/workflows/python-CI.yml
@@ -134,17 +134,17 @@ jobs:
         if: runner.os == 'Linux'
         run: |
           hatch run test:tests --run-postgres
-        continue-on-error: true
+        continue-on-error: false
       - name: Run tests (macOS)
         if: runner.os == 'macOS'
         run: |
           hatch run test:tests
-        continue-on-error: true
+        continue-on-error: false
       - name: Run tests (Windows)
         if: runner.os == 'Windows'
         run: |
           hatch run test:tests
-        continue-on-error: true
+        continue-on-error: false
   integration-test:
     runs-on: ${{ matrix.os }}
     needs: changes

diff --git a/tests/server/api/routers/v1/test_spans.py b/tests/server/api/routers/v1/test_spans.py
@@ -20,8 +20,8 @@ async def test_span_round_tripping_with_docs(
     dialect: str,
     span_data_with_documents: Any,
 ) -> None:
-    if dialect == "sqlite":
-        pytest.xfail("TODO: Convert this to an integration test")
+    # if dialect == "sqlite":
+    #     pytest.xfail("TODO: Convert this to an integration test")
 
     df = cast(pd.DataFrame, px_client.get_spans_dataframe())
     new_ids = {span_id: getrandbits(64).to_bytes(8, "big").hex() for span_id in df.index}