Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP Client JSON node "Delay connection on startup" setting is misleading/incorrectly implemented #74

Open
nagisa opened this issue Jul 21, 2024 · 0 comments

Comments

@nagisa
Copy link
Contributor

nagisa commented Jul 21, 2024

When "Delay connection on startup" is NOT checked, the node will not attempt to auto-connect at all. If it IS checked, then the node will auto-connect.

this.auto_connect = config.wsdelayconnect || false;

However, even if the implementation is adjusted to follow the documentation, which describes the operation in reverse:

<dd>If checked the websocket connection to the CS (CSMS) is not immediately attempted when the flow is started. Instead a message type "99" and command of "connect" must be sent to the node to initiate a connection</dd>

the option name is somewhat confusing (in that it suggests that the checkbox controls some delay, rather than the auto-connection itself.)

I would recommend to rename that option to "Auto-connect on node startup".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant