The Witness: Panel Hunt Plando #3549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
NewSoupVi
force-pushed
the
panel_hunt_plando
branch
from
779573a to
350906a
Compare
NewSoupVi
added
is: enhancement
NewSoupVi
force-pushed
the
panel_hunt_plando
branch
4 times, most recently
from
0d2dcd7 to
4f33f51
Compare
NewSoupVi
force-pushed
the
panel_hunt_plando
branch
from
3c8a849 to
7f56c92
Compare
NewSoupVi
added
waiting-on: peer-review
Exempt-Medic
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
The changes LGTM. I tested various code paths code get hit and functioned properly and have been using this in a lot of my own games lately where it has been working without error. (I might review the full list of plando-able locations later but that doesn't impact this PR since hunts can already land on those panels anyway)
Exempt-Medic
added
the
waiting-on: author
NewSoupVi
removed
the
waiting-on: author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to allow the player to specify which panels they want to be hunt panels in their panel hunt game.
Also fixes some lint/typing stuff in the panel hunt tests
Tested:
This has been played as part of a beta test. Otherwise, test gens hitting every code path