BizHawkClient: Add some handling for non-string errors #2656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Someone reported an error
Essentially the
pcall
forprocess_request
caught an error, and that error was typefunction
, so when the script tried to convert it to JSON to tell the client there was an error, it caused another error.The actual error was an out of bounds write on GBA, and I guess BizHawk's response is to just throw your own function back at you when you cause an error. So in the case of
if
process_request
does an out of bounds write on GBA,response
will be set toprocess_request
. I tried letting it bubble up in BizHawk to see if maybe they used it to print meaningful information about where you did something wrong, but you ultimately just getNLua.Exceptions.LuaException: unprotected error in call to Lua API (0)
. So I don't really think there's anything more to be gleaned from the fact that the error is a function.Out of bounds reads on GBA behave similarly.
How was this tested?
Triggering the error intentionally with Pokemon Emerald and seeing it get passed back to the client as expected.
Didn't do any testing on other systems.