From febe9995a82cdce53cdad8c5aa7401d27d2b61cb Mon Sep 17 00:00:00 2001 From: alwaysintreble Date: Sun, 8 Oct 2023 05:28:58 -0500 Subject: [PATCH] remove ChecksFinder from the list of shame --- test/general/TestItems.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/test/general/TestItems.py b/test/general/TestItems.py index 5a3e6bc9b752..ecd436395a18 100644 --- a/test/general/TestItems.py +++ b/test/general/TestItems.py @@ -64,7 +64,7 @@ def testItemPoolNotModified(self): """Test that worlds don't modify the itempool after `create_items`""" gen_steps = ("generate_early", "create_regions", "create_items") additional_steps = ("set_rules", "generate_basic", "pre_fill") - excluded_games = ("ChecksFinder", "Links Awakening DX", "Ocarina of Time", "SMZ3") + excluded_games = ("Links Awakening DX", "Ocarina of Time", "SMZ3") worlds_to_test = {game: world for game, world in AutoWorldRegister.world_types.items() if game not in excluded_games} for game_name, world_type in worlds_to_test.items(): @@ -72,6 +72,7 @@ def testItemPoolNotModified(self): multiworld = setup_solo_multiworld(world_type, gen_steps) created_items = multiworld.itempool.copy() for step in additional_steps: - call_all(multiworld, step) - self.assertEqual(created_items, multiworld.itempool, - f"{game_name} modified the itempool during {step}") + with self.subTest("step", step=step): + call_all(multiworld, step) + self.assertEqual(created_items, multiworld.itempool, + f"{game_name} modified the itempool during {step}")