From 86da3eb52c9cc41427650b3efe682996eb4d39a1 Mon Sep 17 00:00:00 2001 From: NewSoupVi <57900059+NewSoupVi@users.noreply.github.com> Date: Thu, 6 Jun 2024 03:40:47 +0200 Subject: [PATCH] Remove all functools lru cache (#3446) --- worlds/witness/data/static_logic.py | 9 +++++---- worlds/witness/data/utils.py | 12 ++++++++---- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/worlds/witness/data/static_logic.py b/worlds/witness/data/static_logic.py index bae1921f6095..ecd95ea6c0fa 100644 --- a/worlds/witness/data/static_logic.py +++ b/worlds/witness/data/static_logic.py @@ -1,7 +1,8 @@ from collections import defaultdict -from functools import lru_cache from typing import Dict, List, Set, Tuple +from Utils import cache_argsless + from .item_definition_classes import ( CATEGORY_NAME_MAPPINGS, DoorItemDefinition, @@ -260,17 +261,17 @@ def get_parent_progressive_item(item_name: str) -> str: return _progressive_lookup.get(item_name, item_name) -@lru_cache +@cache_argsless def get_vanilla() -> StaticWitnessLogicObj: return StaticWitnessLogicObj(get_vanilla_logic()) -@lru_cache +@cache_argsless def get_sigma_normal() -> StaticWitnessLogicObj: return StaticWitnessLogicObj(get_sigma_normal_logic()) -@lru_cache +@cache_argsless def get_sigma_expert() -> StaticWitnessLogicObj: return StaticWitnessLogicObj(get_sigma_expert_logic()) diff --git a/worlds/witness/data/utils.py b/worlds/witness/data/utils.py index 5c5568b25661..2934308df3ec 100644 --- a/worlds/witness/data/utils.py +++ b/worlds/witness/data/utils.py @@ -1,4 +1,3 @@ -from functools import lru_cache from math import floor from pkgutil import get_data from random import random @@ -103,10 +102,15 @@ def parse_lambda(lambda_string) -> WitnessRule: return lambda_set -@lru_cache(maxsize=None) +_adjustment_file_cache = dict() + + def get_adjustment_file(adjustment_file: str) -> List[str]: - data = get_data(__name__, adjustment_file).decode("utf-8") - return [line.strip() for line in data.split("\n")] + if adjustment_file not in _adjustment_file_cache: + data = get_data(__name__, adjustment_file).decode("utf-8") + _adjustment_file_cache[adjustment_file] = [line.strip() for line in data.split("\n")] + + return _adjustment_file_cache[adjustment_file] def get_disable_unrandomized_list() -> List[str]: