Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hint previews sooner #152

Open
BadMagic100 opened this issue Jul 17, 2023 · 5 comments
Open

Hint previews sooner #152

BadMagic100 opened this issue Jul 17, 2023 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers mid priority The "default" priority. Made it into a label to be explicit.

Comments

@BadMagic100
Copy link
Contributor

Today, previewable locations hint automatically when you leave the room. This makes some amount of sense, if you see a thing in a shop and immediately buy the thing, you probably don't want it hinted, and shop items do have some indicator of the amount of value, indicating whether they are progression, useful, or not useful.

However, this doesn't account for the fact that progression/useful items may vary in terms of cost vs benefit right now, and some progression/useful items may never be worth the price. In addition, not all previewable locations are shops and may not have this information available on a surface level. What happens in my experience is that players are still asking "is X useful" or reloading the room to hint and then say "are any of those things useful."

Let's just make this easier on players and pull the hints forward to when the IC event fires, knowing that it may create some hints for things which will be bought immediately
@BadMagic100 BadMagic100 added enhancement New feature or request good first issue Good for newcomers mid priority The "default" priority. Made it into a label to be explicit. labels Jul 17, 2023
@BadMagic100
Copy link
Contributor Author

Actually let's make this a mod option, defaulting to the new behavior. Players can choose to revert to the current behavior, or to not create any hints at all

@KonoTyran
Copy link
Contributor

When you say mod option. How do you invision this? As an option on the yaml? Or do we make a config menu option on the pause mod options menu? Or some other method?

@BadMagic100
Copy link
Contributor Author

Yeah, I'm thinking mod menu option. Probably IMenuMod (no satchel) since it's just a simple toggle. I don't believe it's something that belongs in the yaml because it doesn't affect gameplay that much - like, if someone turned it off for a race it wouldn't really matter if you know what you're doing

@BadMagic100
Copy link
Contributor Author

I now believe there is no need for an option controlling this, as hint priority is merged and we can auto hint at low priority now

@BadMagic100
Copy link
Contributor Author

After checking on hint prio details, this can be implemented now, as create_as_hint hints have unspecified priority. But we could also keep a watch on the following pr for a dedicated CreateHints packet as we get no value out of the scouts right now other than the hint ArchipelagoMW/Archipelago#4317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers mid priority The "default" priority. Made it into a label to be explicit.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KonoTyran @BadMagic100