Readme #7
Merged
Readme #7
+93
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 13, 2024 15:20
…management and made changes to the phenotypeomat.toml file to bring it up to date WRT dependencies and naming
…d description of how to interface with the arduino to the README
There was a problem hiding this comment.
some comments and a few small changes but overall this is a great readme! commenting to give @neevor a chance to review, but also ping me when these changes are made. In some places I made suggestions to turn quotes into back ticks. Please feel free to ignore if you don't like that change.
Co-authored-by: Taylor Reiter <[email protected]> Signed-off-by: dgmets <[email protected]>
Co-authored-by: Taylor Reiter <[email protected]> Signed-off-by: dgmets <[email protected]>
Co-authored-by: Taylor Reiter <[email protected]> Signed-off-by: dgmets <[email protected]>
Co-authored-by: Taylor Reiter <[email protected]> Signed-off-by: dgmets <[email protected]>
Co-authored-by: Taylor Reiter <[email protected]> Signed-off-by: dgmets <[email protected]>
Co-authored-by: Taylor Reiter <[email protected]> Signed-off-by: dgmets <[email protected]>
Co-authored-by: Taylor Reiter <[email protected]> Signed-off-by: dgmets <[email protected]>
Co-authored-by: Taylor Reiter <[email protected]> Signed-off-by: dgmets <[email protected]>
… header appear as a header
taylorreiter
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
lgtm -- three things before merging:
- can you check that the phenotypomat.yml env builds with the command in the readme? I've never seen one with spaces between the package and versions but it might be perfectly valid
- you have a typo in the readme for mediated (meddiated i think). Grammarly was really aggressive when i went to fix it as a suggestion and changed the whole tense of the sentence. totally fine you didn't take the suggest, but the typo is still there!
- there are still two typos in status (written as "statis")
neevor
reviewed
Mar 15, 2024
|
|
||
| ### Compute Specifications | ||
| - Arduino Setup: Upload the appropriate .ino sketch to your Arduino device. Ensure that the Arduino is connected to your computer and that the correct port and baud rate are set. |
There was a problem hiding this comment.
Although I'm an awful speller so that might be bad if it looks right to me.
Co-authored-by: Erin <[email protected]> Signed-off-by: dgmets <[email protected]>
|
I checked that the YAML file creates an env and made the formatting and spelling changes. going to merge. Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made several changes. Updated the README, updated the pehnotypeomat.toml, and added a YAML file for a conda env.
I apologize in advance for typos... :)
Thank you!!