Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Type #1

Open
fassko opened this issue Jul 2, 2020 · 4 comments
Open

Dynamic Type #1

fassko opened this issue Jul 2, 2020 · 4 comments

Comments

@fassko
Copy link
Contributor

fassko commented Jul 2, 2020

Feature description

Support Dynamic Type

Problem and motivation

Almost 40% of users have changed their default font size. Especially folks with worse eyesight.

Is this something you're interested in working on

Yes I can help with that

@ULazdins
Copy link
Member

ULazdins commented Jul 2, 2020

@fassko , that's a valid concern, especially given that we want the app to reach broad audiences.

I guess my only question is - what do we need from the design team to make sure that the text doesn't break the visual layout?

@fassko
Copy link
Contributor Author

fassko commented Jul 2, 2020

I think the biggest issue is with bigger (and bold font). Usually, a smaller fit fine.

How we could tackle this problem step by step is to implement Dynamic Type for set up, first screen, and Settings.
Secondly, we could improve other screens like Statistics, Information.

How does that sound?

@fassko
Copy link
Contributor Author

fassko commented Jul 2, 2020

Another idea is to use SwiftUI where Dynamic Type is out of the box. The app supports iOS 13.5+ anyways.

@ArtSp
Copy link
Contributor

ArtSp commented Jul 3, 2020

@fassko , it would be great to start with onboarding storyboards (Welcome.storyboard, CodeEntry.storyboard).

If we are going to implement dynamic types, we must be sure that all text sizes up to Accessibility XXXL will fit the smallest screen size available (SE 1st gen in our case).

You will have to implement scrolling into WelcomeVC to fit larger text sizes. Also make sure SPKC logo will remain visible with larger text sizes. (Logo visibility is optional for SE 1 gen)

For StatsVC you will have to implement dynamic size for collectionView cells. Try keep 2 cells in a row (except SE 1 gen).
For Larger Accessibility Sizes, it is recommended to switch to a single column layout.

Other viewControllers likely will work fine once you will enable dynamic types for their textViews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants