Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labeled inputs - ability to set label's position (left or right) #235

Open
jchojna opened this issue Jul 24, 2020 · 2 comments · May be fixed by #416
Open

Labeled inputs - ability to set label's position (left or right) #235

jchojna opened this issue Jul 24, 2020 · 2 comments · May be fixed by #416
Assignees

Comments

@jchojna
Copy link
Contributor

jchojna commented Jul 24, 2020

Could we allow user to set the label's position easily - so it can be set either on the left or right side of the actual input? I found it hard to customize in css using input's selector. Additionally, I didn't find fomantic class allowing to reverse the order, so maybe adding this functionality could help shiny.semantic to stand out more comparing to our competition?

@dokato
Copy link
Contributor

dokato commented Jul 25, 2020

On that, I also noticed a small inconsistency. Some of our components have label inside their semantic version, some only in shiny version. I think we should keep that consistent, eg. shiny-like function have label, similarly to their shiny equvalent, whereas semantic do not, allowing for greater flexibility like you mentioned above, eg. positioning label however you like.

@dokato
Copy link
Contributor

dokato commented Nov 3, 2020

The task consists of a few steps:

  • normalise how the label is added between the various inputs that use it (note that eg. label of a button it is what is displayed on the button, here we speak about the label that is around the actual input, eg. text above);

  • come up with a solution to customise the label, eg. look at the Fomantic options here: https://fomantic-ui.com/elements/label.html. One idea is to insert default label when only text provided (eg. label = "My Label") and insert customised label when a list (label = list(content = "My Label", position = "top", ...) )

@esraay esraay self-assigned this Jul 8, 2022
@esraay esraay linked a pull request Jul 8, 2022 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants