Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uploading unit test results action in GitHub workflow #13

Open
nenorbot opened this issue Apr 13, 2022 · 1 comment
Open

Fix uploading unit test results action in GitHub workflow #13

nenorbot opened this issue Apr 13, 2022 · 1 comment

Comments

@nenorbot
Copy link
Contributor

In this commit I disabled uploading unit test results, as this action was failing the build. You can see an example of such a failed build here: https://github.com/AppsFlyer/pronto/runs/5107634173?check_suite_focus=true

The impact is that the repo's test coverage badge is out-of-date 🤷

The specific error is:

2022-02-08 10:40:28 +0000 - publish -  INFO - creating check
Traceback (most recent call last):
  File "/action/publish_unit_test_results.py", line 283, in <module>
    main(settings, gha)
  File "/action/publish_unit_test_results.py", line 96, in main
    Publisher(settings, gh, gha).publish(stats, results.case_results, conclusion)
  File "/action/publish/publisher.py", line 63, in publish
    check_run = self.publish_check(stats, cases, conclusion)
  File "/action/publish/publisher.py", line 202, in publish_check
    output=output)
  File "/usr/local/lib/python3.6/site-packages/github/Repository.py", line 3645, in create_check_run
    input=post_parameters,
  File "/usr/local/lib/python3.6/site-packages/github/Requester.py", line 355, in requestJsonAndCheck
    verb, url, parameters, headers, input, self.__customConnection(url)
  File "/usr/local/lib/python3.6/site-packages/github/Requester.py", line 378, in __check
    raise self.__createException(status, responseHeaders, output)
github.GithubException.GithubException: 403 {"message": "Resource not accessible by integration", "documentation_url": "https://docs.github.com/rest/reference/checks#create-a-check-run"}

My guess it's an issue with the GITHUB_TOKEN secret? Maybe it's not injected into this repo?

This was supposed to be a temporary measure but since I'm no longer a member/admin of this organization I can't look into it myself. However, this used to work and all I know at this point is that it broke somewhere between 2021-11-29 and 2022-01-31.

/cc pinging @yonatane -- sorry for waking you, but maybe you know where to redirect this issue internally at AF, to spare this issue from /dev/null

@evg-tso
Copy link
Member

evg-tso commented Sep 12, 2022

AFAIK this stopped working when AF started using the internal single sign-on solution, which messed up the permissions of the GitHub bot.

I've implemented a solution to a similar problem here: AppsFlyer/aerospike-clj#57.
I'll make some time and create a similar solution here as well 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants