Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Could not start a Geth process with only WS or IPC #2377

Merged

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Nov 6, 2024

What I did

Connecting to an already running IPC process or WS-only geth was working great.
However, I could not start one from the beginning this way...

How I did it

Adjust the implementation geth dev process class to handle more connecton inputs, this is the class that actually manages the process when starting it in the ape-node plugin, not the SubprocessProvider class from ape-ethereum, this one comes from the py-geth package.

How to verify it

WITHOUT ALREADY HAVING IT RUNNING:

node:
  ethereum:
    local:
      uri: ws://localhost:5550
      #uri: "http://localhost:5550"
      #uri: /Users/jules/.ape/node/geth.ipc

Comment out the URI types not being used and ensure it works.

More to test and such, opening PR early...

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey force-pushed the fix/allow-ipc-path-when-not-yet-started branch from 3b1614d to a7e3f06 Compare November 21, 2024 18:14
@antazoey antazoey marked this pull request as ready for review November 21, 2024 18:21
@antazoey antazoey marked this pull request as draft November 21, 2024 20:07
@antazoey antazoey force-pushed the fix/allow-ipc-path-when-not-yet-started branch from 9d1ecaf to 88f0173 Compare November 21, 2024 21:43
@antazoey antazoey marked this pull request as ready for review November 21, 2024 21:44
@antazoey antazoey merged commit 0210854 into ApeWorX:main Nov 25, 2024
16 checks passed
@antazoey antazoey deleted the fix/allow-ipc-path-when-not-yet-started branch November 25, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants