fix(0.4): issue when using dependencies that are not installed in site-packages #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
bitwise-constructs
previously approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Difference between this and snekmate_from_pypi?
There was a problem hiding this comment.
I just wanted to show it will still work even when not in the config. The difference is you don't get some of Ape's features with dependencies, but ape-vyper will still work at compiling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
users were unable to use dependencies that were not installed in site-packages (such as using the new pypi: key)
also fixes other annoying issues like a confusing log stmt and over-logging stuff during the compile attempt
ngl, this is a major refactor but vyper 0.4 / snekmate work a lot better now
How I did it
How to verify it
Checklist