Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User disconnecting #47

Open
testbughub opened this issue Sep 18, 2020 · 3 comments
Open

User disconnecting #47

testbughub opened this issue Sep 18, 2020 · 3 comments
Assignees
Labels
Feature Request Request for Features in Future Releases For Investigation help wanted Extra attention is needed Pending Testing

Comments

@testbughub
Copy link

testbughub commented Sep 18, 2020

Is your feature request related to a problem? Please describe.
Not a problem per se.
The way I have it now is, when a user starts a video it writes it to a file,
and when playback is stopped the file is cleared.
Sometimes, some of my users disconnects before stopping the video, so it never clears.

Describe the solution you'd like
A trigger for when a user disconnect.

Describe alternatives you've considered
I haven't figured out a better way to clear the file than to do it manually, but that kinda ruins the whole point of this plugin.

Additional context
emby

@AnthonyMusgrove AnthonyMusgrove self-assigned this Sep 6, 2021
@AnthonyMusgrove AnthonyMusgrove added Feature Request Request for Features in Future Releases For Investigation labels Sep 6, 2021
@AnthonyMusgrove
Copy link
Owner

Thank you @testbughub - I'll check out what we can hook into re Disconnect detection!

@AnthonyMusgrove
Copy link
Owner

I'm trying to replicate the issue mate. Seems at the moment every time I just 'close' the browser, it calls stopPlayback and detects that the session has been closed / user has disconnected.

I'll do more testing to see if I can get it to occur for me too!

@AnthonyMusgrove AnthonyMusgrove added help wanted Extra attention is needed Pending Testing labels Sep 6, 2021
@testbughub
Copy link
Author

testbughub commented Sep 10, 2021

Yes, I've tried replicating it myself with no success, so it doens't happend alot.
It could be because this user watches through his Playstation 4 browser.
Not really sure what else I can provide, and it happens only like 1 out of 30 times, so it's not really that big of a deal.
I was a while ago now though, so I haven't seen it for a long time since.
You could close this issue if you want to.
Whatever you choose to do, thank you regardless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Request for Features in Future Releases For Investigation help wanted Extra attention is needed Pending Testing
Projects
None yet
Development

No branches or pull requests

2 participants