IF: reenable weak vote related tests #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
approved these changes
Feb 17, 2024
heifner
approved these changes
Feb 17, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to #2135, weak votes and strong votes were signed using the same digest. The weak votes related tests in finality_tests.cpp were constructed based on the same digest; those tests had to be disabled to get #2135 to move ahead.
This PR fixes the issue by implementing
controller::get_strong_digest_by_idto return strong digest of a block given a block ID, makingtester::set_finalizersto return private keys of local finalizer, and signing weak votes. All disabled tests have been re-enabled.Resolved #2193