Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0] move some tests that open localhost sockets to NP tests #2214

Merged
merged 1 commit into from
Feb 6, 2024
Merged

[5.0] move some tests that open localhost sockets to NP tests #2214

merged 1 commit into from
Feb 6, 2024

Conversation

spoonincode
Copy link
Member

Any test that listens on a localhost socket is required to be in NP tests currently. Resolves #2213

@spoonincode spoonincode linked an issue Feb 6, 2024 that may be closed by this pull request
trx_generator_tests test failure on 5.0 release branch #2213
Closed
@spoonincode spoonincode merged commit f67a842 into release/5.0 Feb 6, 2024
29 checks passed
@spoonincode spoonincode deleted the nptests_50 branch February 6, 2024 15:20
@spoonincode spoonincode mentioned this pull request Feb 6, 2024
Merged
@ericpassmore
Copy link
Contributor

Note:start
group: CLEANCODE
category: TEST
summary: Reorganize tests that listen on local socket.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

@heifner heifner heifner approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trx_generator_tests test failure on 5.0 release branch
5 participants
@spoonincode @ericpassmore @greg7mdp @heifner @linh2931