IF: Add a new set_finalizer (with weights, threshold, and local finalizer) to libtester and add more tests using it #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o libtester; add more unittests for finality transition using the new function
heifner
requested changes
Feb 5, 2024
greg7mdp
approved these changes
Feb 5, 2024
unittests/api_tests.cpp
Outdated
| "alice"_n, "bob"_n, "carol"_n | ||
| }; | ||
|
|
||
| base_tester::finalizer_policy_input ploicy_input = { |
There was a problem hiding this comment.
type in all the ploicy_input.
|
|
||
| // libtester uses 1 as weight of each of the finalizer, sets (2/3 finalizers + 1) | ||
| // as threshold, and makes all finalizers vote QC | ||
| transaction_trace_ptr set_finalizers(const vector<account_name>& finalier_names); |
…onst finalizer_policy_input&); correct 2 typos
heifner
approved these changes
Feb 6, 2024
|
Note:start |
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
threshold_equal_to_half_weight_sum_test,votes_equal_to_threshold_test,votes_greater_than_threshold_test, andvotes_less_than_threshold_test.Resolved #2193