Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Fix sigsegv in the use of process_vote_message #2185

Merged
merged 1 commit into from
Feb 2, 2024
Merged

IF: Fix sigsegv in the use of process_vote_message #2185

merged 1 commit into from
Feb 2, 2024

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Feb 1, 2024 •
edited
Loading

Thanks @spoonincode for getting us the core backtrace and @heifner for suggesting the fix.

A reference of control caught by a lamda in process_vote_message lived past its destruction and caused the crash.

Resolved #2184

@linh2931 linh2931 requested review from heifner and greg7mdp February 1, 2024 23:48
@linh2931 linh2931 merged commit 4033fba into hotstuff_integration Feb 2, 2024
26 checks passed
@linh2931 linh2931 deleted the fix_sigsegv branch February 2, 2024 01:59
@linh2931 linh2931 mentioned this pull request Feb 2, 2024
Merged
@ericpassmore
Copy link
Contributor

ericpassmore commented Feb 2, 2024 •
edited
Loading

Note:start
group: IF
category: INTERNALS
summary: Clean up dangling references in process_vote_message, and prevent associated crash.
Note:end

@heifner heifner mentioned this pull request Feb 2, 2024
Merged
heifner added a commit that referenced this pull request Feb 2, 2024
@heifner
GH-2175 Enable tests now that GH-2185 and GH-2182 fixed.
bd076de
@heifner heifner mentioned this pull request Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@linh2931 @ericpassmore @greg7mdp @heifner