Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Provide finality_data in SHiP for Transition Savanna Blocks #2360

Closed
linh2931 opened this issue Mar 29, 2024 · 0 comments · Fixed by #2362
Closed

IF: Provide finality_data in SHiP for Transition Savanna Blocks #2360

linh2931 opened this issue Mar 29, 2024 · 0 comments · Fixed by #2362
Assignees
@linh2931
Labels
👍 lgtm
Milestone
Instant Finality:...

Comments

@linh2931
Copy link
Member

linh2931 commented Mar 29, 2024 •
edited by arhag
Loading

SHiP support of IBC was implemented before proper Savanna transition was implemented. It was based on instant transition where Transition Savanna Blocks were not applicable. Now that proper Savanna transition has been implemented, @systemzax reports the finality_data for the Transition Blocks are not provided by SHiP.

Need to update code to provide finality_data for Transition blocks.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Mar 29, 2024
@linh2931 linh2931 self-assigned this Mar 29, 2024
@linh2931 linh2931 added 👍 lgtm and removed triage labels Mar 29, 2024
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Mar 29, 2024
@linh2931 linh2931 added this to the Instant Finality: Cusp milestone Mar 29, 2024
@linh2931 linh2931 mentioned this issue Mar 29, 2024
Merged
@arhag arhag modified the milestones: Instant Finality: Cusp, Instant Finality: Production-Ready Apr 1, 2024
@arhag arhag linked a pull request Apr 3, 2024 that will close this issue
IF: SHiP -- Provide finality_data for Transition blocks #2362
Merged
@linh2931 linh2931 moved this from In Progress to Done in Team Backlog Apr 4, 2024
@linh2931 linh2931 closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linh2931 linh2931

Labels
👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
Instant Finality: Production-Ready
Development

Successfully merging a pull request may close this issue.

IF: SHiP -- Provide finality_data for Transition blocks AntelopeIO/leap
3 participants
@arhag @linh2931 @enf-ci-bot