-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IF: add more flexibility for IF transition to Boost libtester #2193
Comments
Libtester should have functionality to allow for tests with explicit control of votes: how they vote (strong/weak) via manipulation of finalizer safety information, where the votes arrive (which nodes or instances of libtester), and when the votes arrive. |
Manipulating finalizer safety info is now in #2233. |
weak vote tests are not passing and were disabled. Reopening until these tests can be re-enabled. |
After the finality safety info feature is in, we cannot simply change vote message to simulate weak votes, as now signatures are different for strong and weak votes. Need to manipulate finality safety info. |
Currently
set_finalizers
of libtester takes only a vector of producer names for IF transision.set_finalizer
hardcodes the threshold and weights for each producer and sets up all producers to vote in the node.To facilitate more complex tests,
set_finalizer
or another function liketransition_to_if
should take threshold, weights, and voting producers as parameters to set up IF testing.Tests using the new function will be added in the same PR resolving the issue.
The text was updated successfully, but these errors were encountered: