Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: add more flexibility for IF transition to Boost libtester #2193

Closed
Tracked by #2110
linh2931 opened this issue Feb 2, 2024 · 4 comments · Fixed by #2234
Closed
Tracked by #2110

IF: add more flexibility for IF transition to Boost libtester #2193

linh2931 opened this issue Feb 2, 2024 · 4 comments · Fixed by #2234
Assignees

Comments

@linh2931
Copy link
Member

linh2931 commented Feb 2, 2024

Currently set_finalizers of libtester takes only a vector of producer names for IF transision. set_finalizer hardcodes the threshold and weights for each producer and sets up all producers to vote in the node.

To facilitate more complex tests, set_finalizer or another function like transition_to_if should take threshold, weights, and voting producers as parameters to set up IF testing.

Tests using the new function will be added in the same PR resolving the issue.

@arhag
Copy link
Member

arhag commented Feb 5, 2024

Libtester should have functionality to allow for tests with explicit control of votes: how they vote (strong/weak) via manipulation of finalizer safety information, where the votes arrive (which nodes or instances of libtester), and when the votes arrive.

@linh2931
Copy link
Member Author

Manipulating finalizer safety info is now in #2233.

@greg7mdp
Copy link
Contributor

weak vote tests are not passing and were disabled. Reopening until these tests can be re-enabled.

@greg7mdp greg7mdp reopened this Feb 16, 2024
@github-project-automation github-project-automation bot moved this from Done to Todo in Team Backlog Feb 16, 2024
@linh2931
Copy link
Member Author

After the finality safety info feature is in, we cannot simply change vote message to simulate weak votes, as now signatures are different for strong and weak votes. Need to manipulate finality safety info.

@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Feb 16, 2024
@linh2931 linh2931 moved this from In Progress to Done in Team Backlog Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment