Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: Fix SIGSEGV when create_and_send_vote_msg processes its own vote #2184

Closed
Tracked by #2110
linh2931 opened this issue Feb 1, 2024 · 0 comments
Closed
Tracked by #2110
Assignees

Comments

@linh2931
Copy link
Member

linh2931 commented Feb 1, 2024

SIGSEGV happened frequently in IF Boost unittests and occasionally in Integration tests. Thanks to @spoonincode, a back trace was retrieved from CICD (the problem did not happen in local testing):

3 controller_impl::set_if_irreversible_block_num(uint32_t) ()
4 cotroller::process_vote_message( const vote_message& ) ()
5 controller_impl::create_and_send_vote_msg()
...
9 name_thread_pool<controller_impl::chain> run_thread()

The issue was when processing its own vote, create_and_send_vote_msg posts process_vote_message to the thread pool with a reference which can be destructed before its use.

@linh2931 linh2931 self-assigned this Feb 1, 2024
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Feb 1, 2024
@linh2931 linh2931 added this to the Leap v6.0.0-rc1 milestone Feb 1, 2024
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Feb 1, 2024
@linh2931 linh2931 changed the title IF: Fix SIGSEGV IF: Fix SIGSEGV in the use of process_vote_message Feb 1, 2024
@linh2931 linh2931 added 👍 lgtm and removed triage labels Feb 2, 2024
@linh2931 linh2931 changed the title IF: Fix SIGSEGV in the use of process_vote_message IF: Fix SIGSEGV when create_and_send_vote_msg processes its own vote Feb 2, 2024
@linh2931 linh2931 moved this from In Progress to Done in Team Backlog Feb 2, 2024
@linh2931 linh2931 closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants