Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Add new snapshot version to hold consensus Savanna state #1558

Closed
Tracked by #2110
heifner opened this issue Aug 24, 2023 · 1 comment · Fixed by #2297
Closed
Tracked by #2110

IF: Add new snapshot version to hold consensus Savanna state #1558

heifner opened this issue Aug 24, 2023 · 1 comment · Fixed by #2297
Assignees
@greg7mdp
Labels
👍 lgtm
Milestone
Leap v6.0.0-rc1

Comments

@heifner
Copy link
Member

heifner commented Aug 24, 2023 •
edited by arhag
Loading

Depends on #1523 and #2080.

We will store the active finalizer set in the snapshot. Note this will be a non-backwards compatible snapshot version. Leap 5.0 can import older versions of snapshots that it currently supports, but it can only export the new version of the snapshot (v7).

Remove if not activateIF from ship_streamer_test.py and uncomment nodeos_snapshot_diff_if_test in tests/CMakeLists.txt.
@heifner heifner mentioned this issue Aug 24, 2023
Closed
@heifner heifner mentioned this issue Aug 30, 2023
Closed
@arhag arhag added 👍 lgtm and removed triage labels Aug 30, 2023
heifner added a commit that referenced this issue Sep 5, 2023
@heifner
GH-1523 Comment out test until it can be worked under GH-1558
b92aa6a
@heifner heifner mentioned this issue Sep 5, 2023
Merged
@linh2931 linh2931 self-assigned this Sep 12, 2023
@linh2931
Copy link
Member

Will get the wiring ready first.

@bhazzard bhazzard added this to the Leap v6.0.0-rc1 milestone Nov 1, 2023
@arhag arhag mentioned this issue Jan 19, 2024
Closed
This was referenced Jan 30, 2024
Merged
Merged
@BenjaminGormanPMP BenjaminGormanPMP moved this from Todo to In Progress in Team Backlog Mar 5, 2024
@greg7mdp greg7mdp mentioned this issue Mar 9, 2024
Merged
@greg7mdp greg7mdp linked a pull request Mar 9, 2024 that will close this issue
IF: Add new snapshot version to hold consensus hotstuff state #2297
Merged
@arhag arhag closed this as completed Mar 11, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Mar 11, 2024
@arhag arhag changed the title IF: Add new snapshot version to hold consensus hotstuff state IF: Add new snapshot version to hold consensus Savanna state Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greg7mdp greg7mdp

Labels
👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
Leap v6.0.0-rc1
Development

Successfully merging a pull request may close this issue.

IF: Add new snapshot version to hold consensus hotstuff state AntelopeIO/leap
6 participants
@bhazzard @greg7mdp @heifner @arhag @linh2931 @enf-ci-bot