Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: HotStuff code cleanup #1520

Closed
arhag opened this issue Aug 17, 2023 · 3 comments
Closed

IF: HotStuff code cleanup #1520

arhag opened this issue Aug 17, 2023 · 3 comments

Comments

@arhag
Copy link
Member

arhag commented Aug 17, 2023

  • Address style inconsistency
  • Remove extraneous comments
  • Easy optimization (address pass-by-value arguments)
  • Change unit tests that could easily run in parallel so that they run as part of our parallelizable tests.
@heifner
Copy link
Member

heifner commented Aug 18, 2023

  • Fix all warnings
  • Verify all TODOs have been addressed

@greg7mdp
Copy link
Contributor

greg7mdp commented Aug 18, 2023

  • Use compact namespace syntax: namespace eosio::chain { ... };

@arhag
Copy link
Member Author

arhag commented Feb 23, 2024

Overcome by events.

@arhag arhag closed this as completed Feb 23, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Team Backlog Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants