Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Rename set_finalizers types to match eosio.bios and leap names #259

Merged
merged 3 commits into from
Dec 20, 2023
Merged

IF: Rename set_finalizers types to match eosio.bios and leap names #259

merged 3 commits into from
Dec 20, 2023

Conversation

heifner
Copy link
Member

@heifner heifner commented Dec 19, 2023 •
edited
Loading

Change Description

Rename finalizer_authority, finalizer_policy types to match eosio.bios and leap names.

Depends on: AntelopeIO/leap#2004 for tests.

API Changes

  • [ x ] API Changes

Documentation Additions

  • [ x ] Documentation Additions

Resolves #257

@heifner heifner linked an issue Dec 19, 2023 that may be closed by this pull request
IF: unifying set_finalizers interface with Leap and BIOS Contract #257
Closed
@heifner heifner added the OCI Work exclusive to OCI team label Dec 19, 2023
linh2931
linh2931 reviewed Dec 19, 2023
View reviewed changes
Copy link
Member

@linh2931 linh2931 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests in instant_finality_tests.cpp need to be changed as they use old field names.

@heifner heifner merged commit b1eacc8 into hotstuff_integration Dec 20, 2023
11 of 12 checks passed
@heifner heifner deleted the GH-257-set-finalizers-types-rename branch December 20, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IF: unifying set_finalizers interface with Leap and BIOS Contract
3 participants
@heifner @greg7mdp @linh2931