Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary array assignment in hydro optimization management #2152

Open
nikolaredstork opened this issue Jun 10, 2024 · 0 comments
Open

Unnecessary array assignment in hydro optimization management #2152

nikolaredstork opened this issue Jun 10, 2024 · 0 comments

Comments

@nikolaredstork
Copy link
Collaborator

In mothly hydro management, when reservoir management is not used, monthly optimal levels array is populated with average reservoir levels. Don't see purpose of assigning monthly optimal level array when reservoir management is not used, in this case there is no reservoir to be filled with inflows and we don't need any arrays that represents reservoir levels. In src/solver/hydro/management/montlhy.cpp file, you can find that one line of code that I found unnecessary, function is called prepareMonthlyOptimalGenerations.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants