Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is possible to create an invalid command on a variant that will break it #1460

Open
2 tasks done
MartinBelthle opened this issue Apr 18, 2023 · 0 comments
Open
2 tasks done
Labels
bug Something isn't working

Comments

@MartinBelthle
Copy link
Contributor

MartinBelthle commented Apr 18, 2023

Description

For example, it is possible to create a cluster that already exists. But when the variant is regenerated, it will fail with an HTTP 417 because the command is invalid (the cluster already exists).

Steps to Reproduce

Steps to reproduce the behavior:

1- Create a base study with 1 area and 1 thermical cluster
2- Create a variant
3- Create a thermal cluster of the same type with the same name on the variant -> It will add the command in the command list
4- Try to generate variant -> It will fail because the command is invalid

Actual Behavior

The variant is broken

Expected Behavior

The command should fail before being add to the command list

Screenshots

If applicable, add screenshots to help explain your problem.

Possible Solution

Check command validity before adding it.

Environment

  • Production
  • Staging
@MartinBelthle MartinBelthle added the bug Something isn't working label Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant