Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blank trustedhosts #4

Open
hg77 opened this issue Aug 24, 2017 · 0 comments
Open

blank trustedhosts #4

hg77 opened this issue Aug 24, 2017 · 0 comments

Comments

@hg77
Copy link

hg77 commented Aug 24, 2017

I ran into some annoyance with RemoteUserJiraAuth.properties
The comment says "Leave blank to allow all hosts." and shows
#trustedhosts=
as example. However
trustedhosts=
in the properties file wont work, because you only check if trustedhosts is not set, not if it is set to an empty value (at least that seems to be the problem I ran in).
Quickest would be to change the doc to "Don't set to allow all hosts." and remove
#trustedhosts=

Thank you very much for this very handy plugin.
Sam-Hall added a commit to Sam-Hall/remoteuserauth that referenced this issue Aug 2, 2019
@Sam-Hall
Added features to auto-activate users and support email format userna…
60aac75 
…mes (avoid removing the domain/realm from the SSO username value). Changed the location of the properties file (breaking change, move properties file to CATALINA_HOME/conf after update). Resolves AngusWarren#2, resolves AngusWarren#3 and resolves AngusWarren#4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hg77