Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevalence division option #34

Open
3 of 4 tasks
fredjaya opened this issue Apr 16, 2024 · 5 comments
Open
3 of 4 tasks

Prevalence division option #34

fredjaya opened this issue Apr 16, 2024 · 5 comments
Assignees
Milestone

Comments

@fredjaya
Copy link
Collaborator

fredjaya commented Apr 16, 2024

Not yet deployed as of writing this, but a9a5c6a introduces an option to divide prevalence and CI/CrI outputs by a provided value (2000 by default). Minimal testing completed, but some outstanding issues/to-dos:

  • Does not multiply prevalence by default
  • No sanity checks as of yet
  • Rename columns when applied (e.g. Prevalence per N units)
  • Does not update automatically
@AngusMcLure
Copy link
Owner

I had quick play with this on my machine. Sorry, there was a bit of a confusion and I perhaps should have picked up on this from our conversation. The prevalence value outputted by PoolPrev etc. needs to be multiplied by a value, not divided by it.

Multiplying by 100 would give the prevalence per 100 units (i.e. the prevalence as a percentage)

Multiplying by 2000 would give you the prevalence per 2000 units etc.

I think the confusion comes because we talk about prevalence per X.

@fredjaya
Copy link
Collaborator Author

Thanks for catching that, will push and deploy shortly.

Was getting it running locally straightforward?

@AngusMcLure
Copy link
Owner

AngusMcLure commented Apr 16, 2024 via email

@fredjaya
Copy link
Collaborator Author

Will need to double check but I think the workflow should be something like:

renv::install()
renv::activate()

Then run app

@fredjaya fredjaya reopened this Apr 16, 2024
@fredjaya fredjaya reopened this Apr 16, 2024
@fredjaya fredjaya added this to the next milestone Apr 29, 2024
@caitlinch
Copy link
Collaborator

I updated the prevalence multiplication code for both MLE and Bayesian.
When N != 1, any prevalence columns in the output data frame are multiplied by that N, and the prevalence columns are renamed to append "per N units".
When N=1, there is no change to the prevalence columns.

I implemented the boolean flag documented by Fred for when no multiplication is desired, which sets N=1.

The ICC columns are not affected by N and do not undergo multiplication.

Still no sanity checks - specifically, consider negative N values.

@caitlinch caitlinch mentioned this issue Oct 21, 2024
2 tasks
caitlinch added a commit that referenced this issue Oct 21, 2024
Prevalence - add label to prevalence column "per X units", where X is user-specified input (default = 1, no multiplication).

ICC columns - update column names to remove ICC from Credible Intervals (reduce repetition, shorten the long column names).

Complete GH-38
Progress on GH-34
@caitlinch caitlinch self-assigned this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants