Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge test-suite branch to main #32

Open
10 of 12 tasks
caitlinch opened this issue Dec 19, 2024 · 1 comment
Open
10 of 12 tasks

Merge test-suite branch to main #32

caitlinch opened this issue Dec 19, 2024 · 1 comment
Assignees

Comments

@caitlinch
Copy link
Collaborator

caitlinch commented Dec 19, 2024

Complete test-suite branch on Caitlin's fork and merge to main

  • Test PoolPrev() with input data checks
  • Fix any PoolPrev() issues
  • Test HierPoolPrev() with input data checks
  • Fix any HierPoolPrev() issues
  • R CMD CHECK
  • Resolve ERRORS
  • Resolve WARNINGS
  • Resolve NOTES
  • Fix broken tests
  • Redo R CMD CHECK
  • Pull request
  • Merge branch
@caitlinch caitlinch self-assigned this Dec 19, 2024
@caitlinch
Copy link
Collaborator Author

Due to the recursive structure of PoolPrev() and HierPoolPrev(), I exported the CheckInputData() as a function for users to apply directly. I attempted to implement within PoolPrev() and HierPoolPrev(), but the recursion limits the use of the checks. The main issue was that restricting the input data meant when the function called again, it raised an error (i.e., input data type went from data.frame to tibble) and I couldn't see a clear way to distinguish the initial and subsequent calls without adding another input variable to the functions.

There is probably a better way to implement the checks within these functions, which I leave as an exercise to the next developer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant