Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MLE estimation procedure in PoolPrev to have non-random initialisation #11

Open
AngusMcLure opened this issue Oct 18, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@AngusMcLure
Copy link
Owner

This will mean that the MLE will have the same result every time. Currently the differences between runs are small, but may confuse a user that doesn't understand numerical root-finding methods.

Alternative would be to round all results by an amount appropriate for the numerical precision of results. If random initial seed is causing differences above an beyond this, the this suggests there is something wrong with the model/code, so may be more helpful to identify issues than simple setting the seed to be fixed

@AngusMcLure AngusMcLure added the enhancement New feature or request label Oct 18, 2022
@caitlinch
Copy link
Collaborator

@AngusMcLure - we chatted about this the other day, so I'm flagging that we have an existing issue for it

@caitlinch
Copy link
Collaborator

After this is fixed, the tolerance for ML prevalence estimates in the PoolPrev() tests can be updated (see file tests/test-PoolPrev.R)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants