Only download list once per run #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That was presumably the intention of naming the variable `list_url`, but surrounding it with `""` prevents this from working properly.
Uses a temporary file to store the list of trackers.
…d-auto.sh and tracker-add-auto-router.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make it work with multiple URLs in
list_urlThat was presumably the intention of naming the variable
list_url, but surrounding it with""prevents this from working properly.Only download list(s) of trackers ONCE per run
Uses a temporary file to store the list of trackers.
fix indentation, and move subroutine out of while loop, in tracker-add-auto.sh and tracker-add-auto-router.sh
use
list_urlvariable in all scripts