From b214bac2795effddf055eba7c73235bb7d9fda90 Mon Sep 17 00:00:00 2001 From: Tobias Barsnes Date: Mon, 11 Nov 2024 13:53:12 +0100 Subject: [PATCH] feat: remove `ds-reset` (#2755) resolves #2751 --- packages/css/base/ds-reset.css | 14 -------------- packages/css/combobox.css | 5 +++++ packages/css/index.css | 3 +-- 3 files changed, 6 insertions(+), 16 deletions(-) delete mode 100644 packages/css/base/ds-reset.css diff --git a/packages/css/base/ds-reset.css b/packages/css/base/ds-reset.css deleted file mode 100644 index 38a93051ff..0000000000 --- a/packages/css/base/ds-reset.css +++ /dev/null @@ -1,14 +0,0 @@ -/* https://piccalil.li/blog/a-more-modern-css-reset/ */ - -/* https://wiki.csswg.org/ideas/mistakes */ - -/* Inherit fonts for inputs and buttons */ -input[class^='ds-'], -textarea[class^='ds-'], -select[class^='ds-'] { - box-sizing: border-box; - font-family: inherit; - font-size: inherit; - line-height: inherit; - font-weight: inherit; -} diff --git a/packages/css/combobox.css b/packages/css/combobox.css index 5cd4c922ec..06459c9ce8 100644 --- a/packages/css/combobox.css +++ b/packages/css/combobox.css @@ -46,6 +46,11 @@ border: none; background-color: transparent; color: var(--ds-color-neutral-text-default); + box-sizing: border-box; + font-family: inherit; + font-size: inherit; + line-height: inherit; + font-weight: inherit; } .ds-combobox--sm .ds-combobox__input__wrapper { diff --git a/packages/css/index.css b/packages/css/index.css index ad4f21ace8..5f564e3461 100644 --- a/packages/css/index.css +++ b/packages/css/index.css @@ -1,9 +1,8 @@ @charset 'UTF-8'; -@layer ds.reset, ds.base, ds.typography, ds.theme, ds.components; +@layer ds.base, ds.typography, ds.theme, ds.components; /** Import order defines ordinal specificity for layers */ -@import url('./base/ds-reset.css') layer(ds.reset); @import url('./base/base.css') layer(ds.base); @import url('./heading.css') layer(ds.typography); @import url('./label.css') layer(ds.typography);