diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 62c8a44982..e650d08213 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -139,23 +139,21 @@ You can use any editor you like, but if you use [Visual Studio Code](https://cod To enable correct validation and to fix lint/style errors on save, add this to your VSCode `settings.json`: - - ```json +{ "eslint.useFlatConfig": true, "css.validate": false, "scss.validate": false, "stylelint.validate": ["css", "scss"], "editor.codeActionsOnSave": { "source.fixAll.eslint": true, - "source.fixAll.stylelint": true, + "source.fixAll.stylelint": true }, "editor.defaultFormatter": "esbenp.prettier-vscode", - "editor.formatOnSave": true, + "editor.formatOnSave": true +} ``` - - ### Run storybook diff --git a/eslint.config.mjs b/eslint.config.mjs index 01aec909b6..f70ef7c709 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -66,6 +66,7 @@ export default tseslint.config( react: { version: 'detect' }, }, rules: { + '@typescript-eslint/consistent-type-definitions': ['error', 'type'], 'array-callback-return': [ 'error', { @@ -229,8 +230,6 @@ export default tseslint.config( rules: { ...mdx.flatCodeBlocks.rules, '@typescript-eslint/no-unused-vars': 'off', - 'no-undef': 'off', - 'react/jsx-no-undef': 'off', }, }, ) diff --git a/proprietary/react-icons/README.md b/proprietary/react-icons/README.md index cf5b099ad0..0ba6b47575 100644 --- a/proprietary/react-icons/README.md +++ b/proprietary/react-icons/README.md @@ -19,11 +19,12 @@ npm install @amsterdam/design-system-react-icons Import the component for the icon you need, as well as the generic Icon component, and use them in your JSX. -```ts -import { Icon } from "@amsterdam/design-system-react"; -import { SearchIcon } from "@amsterdam/design-system-react-icons"; + +```tsx +import { Icon } from "@amsterdam/design-system-react" +import { SearchIcon } from "@amsterdam/design-system-react-icons" -export const App = () => ; +export const App = () => ``` ## Updating