Update parent fires twice

[bryanspears]

Due to: https://github.com/AmpersandJS/ampersand-input-view/blob/master/ampersand-input-view.js#L68

Parent update gets duplicate call. At least it appears to be duplicated. I don't see any differences on the object passed.

Not sure what a proper fix would be. One suggestion would be to mimic the event pattern and send another argument that tells the parent which event is being fired.

[pgilad]

Absolutely agree. change:valid should not trigger a parent.update().

[cdaringe]

@pgilad, do you mean change:value?

[pgilad]

No I think update should update the parent on value changes, not on valid changes?

[cdaringe]

http://ampersandjs.com/learn/forms#form-input-view-conventions

It reports changes to its parent when it deems appropriate by calling this.parent.update(this) **note that it passes itself to the parent. You would typically do this when the this.value has changed or the this.valid has changed.

in the grand scheme, i suppose that a value change transitively drives valid change, so two events may not be reqd. im not sure if that covers all cases tho. e.g. can valid ever change without value changing? the form itself should be checking child fields for validity on update regardless, supporting your guys' points

can valid ever change without value changing
let's agree to an answer on this, and if it comes out with a 'yes', lets drop the valid evt and update the docs. gotta run!